Skip to content
This repository was archived by the owner on Dec 28, 2024. It is now read-only.

Conversation

@pogi7
Copy link
Collaborator

@pogi7 pogi7 commented May 6, 2024

Description

Please include a summary of the change and its subsequent issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

  1. move FrontPage to pages directory
  2. refactor cardData to have icon and button information

Subsequent # LL-230

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  1. Go to the front page and verify that the Login and Register buttons work in Light Mode and Dark Mode
  2. Verify that the buttons in the Footer work as well

Checklist (when relevant):

  • My code follows the style guidelines of this project
    TypeScript
    Schema
  • I have included a reviewer on the pull request @greypilgrim @aematei
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pogi7 pogi7 requested review from aematei and greypilgrim May 6, 2024 05:45
Copy link
Collaborator

@aematei aematei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log in and register buttons work in light and dark mode as expected, but this is how the front page looks:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants